Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed humanname for zypperpkg #62086

Merged
merged 6 commits into from
Oct 20, 2022

Conversation

515k4
Copy link
Contributor

@515k4 515k4 commented May 19, 2022

What does this PR do?

The pkgrepo renames humanname argument to name for RedHat ana Suse os_family but zypperpkg does expect only humanname. Moreover the argument is missing in documentation and it used --name='{0}' which leaves trailing single quote marks as part of the name.

What issues does this PR fix or reference?

Fixes: #62053

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@515k4 515k4 requested a review from a team as a code owner May 19, 2022 19:03
@515k4 515k4 requested review from twangboy and removed request for a team May 19, 2022 19:03
@welcome
Copy link

welcome bot commented May 19, 2022

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need a changelog and some tests written.

salt/modules/zypperpkg.py Outdated Show resolved Hide resolved
@515k4
Copy link
Contributor Author

515k4 commented Oct 16, 2022

This will also need a changelog and some tests written.

I added both changelog and simple test.

@515k4 515k4 requested a review from twangboy October 16, 2022 11:47
@garethgreenaway garethgreenaway merged commit 75a6ffd into saltstack:master Oct 20, 2022
@welcome
Copy link

welcome bot commented Oct 20, 2022

Congratulations on your first PR being merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The humanname is ignored in pkgrepo.managed on openSUSE Leap (zypper repo)
3 participants