Check dict key get_reboot_active exists before attempting to use, not all proxy implement it #60244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all proxy implement it
dmurphy18
requested review from
joechainz and
garethgreenaway
and removed request for
a team and
joechainz
|
re-run full all |
garethgreenaway
approved these changes
May 25, 2021
xeacott
approved these changes
May 25, 2021
s0undt3ch
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue with proxy get_boot_active key missing error in logs, by checking if key exists first before trying it.
This is necessary since not all proxy's implement 'get_reboot_active', for example: napalm
Originally added to fix issue with junos keep alive
What issues does this PR fix or reference?
Fixes: #60025
Previous Behavior
KeyError: 'napalm.get_reboot_active' traceback error in logs
New Behavior
no message output to logs, since key now only accessed if exists.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.