Port #49480 to master #56830
Closed
Port #49480 to master #56830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
DmitryKuzmenko
force-pushed
the
master-port-49480
branch
from
d1593d5
to
539a019
Compare
Salt-based supportconfig. Re-implementation of Support Config Tool in Salt.
DmitryKuzmenko
force-pushed
the
master-port-49480
branch
from
3515ed0
to
1b66a9a
Compare
os.access documentation notes it could be false-positive in some cases like network filesystems. So we have to catch the permission error anyway that makes using of os.access check redundant.
s0undt3ch
reviewed
Sep 2, 2020
salt/cli/support/collector.py
Outdated
| self.out.error(ret) | ||
| except Exception as ex: # pylint: disable=broad-except | ||
| ret = "Unhandled exception occurred: {}".format(ex) | ||
| log.debug(ex, exc_info=True) |
There was a problem hiding this comment.
The purpose is to collect all events so it just puts the error as well.
There was a problem hiding this comment.
Sure, but the above ret is not used. I guess it was supposed to be on the log call, of not, nuke it.
There was a problem hiding this comment.
Ah, I got you. Sorry.
dwoz
added
the
Needs-Testcase
|
Superseded by #57054 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #49480 to master
Salt-based supportconfig. Re-implementation of Support Config Tool in
Salt.