Port #51012 to master #56779
Closed
Port #51012 to master #56779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling cmd.run with cwd in combination with runas the working directory was not set on macOS This commit also adds a test to check the expected behaviour Co-authored-by: Wayne Werner <[email protected]>
ghost
requested review from
This also includes a .keep file so git will never get rid of the changelog directory.
|
@waynew Test failures look legit |
Apparently Windows and Mac really do not like that test.
|
Heh. Looks like those |
|
Turns out that a better change was already in master 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports #51012 to master
When calling cmd.run with cwd in combination
with runas the working directory was not set on macOS
This commit also adds a test to check the expected behaviour
What issues does this PR fix or reference?
PR #51012
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes