Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate smartos mdata grains #55609

Merged
merged 5 commits into from
Dec 14, 2019
Merged

Deprecate smartos mdata grains #55609

merged 5 commits into from
Dec 14, 2019

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Dec 11, 2019

What does this PR do?

deprecate some smartos grains

What issues does this PR fix or reference?

#49420

Previous Behavior

the smartos grains hypervisor_uuid and datacenter were still apart of the grains.

New Behavior

Remove some smartos grains:

  • The hypervisor_uuid has been replaced with mdata:sdc:server_uuid grain.
  • The datacenter has been replaced with mdata:sdc:datacenter_name grain.

Tests written?

No - removing legacy code

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from a team as a code owner December 11, 2019 20:41
@ghost ghost requested a review from waynew December 11, 2019 20:41
@dwoz
Copy link
Contributor

dwoz commented Dec 14, 2019

The last change was just a merge conflict in docs. Tests passed otherwise.

@dwoz dwoz merged commit 858627b into saltstack:master Dec 14, 2019
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@882a832). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55609   +/-   ##
=========================================
  Coverage          ?   39.06%           
=========================================
  Files             ?     1467           
  Lines             ?   260302           
  Branches          ?    56406           
=========================================
  Hits              ?   101659           
  Misses            ?   147293           
  Partials          ?    11350
Flag Coverage Δ
#m2crypto 38.5% <ø> (?)
#py2 38.67% <ø> (?)
#py3 38.5% <ø> (?)
#runtests 39.06% <ø> (?)
#ubuntu1604 39.06% <ø> (?)
#zeromq 39.06% <ø> (?)
Impacted Files Coverage Δ
salt/grains/mdata.py 25.38% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants