-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the proxmox VM when using clone in the salt-cloud profile if settings are present #55060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akm0d
force-pushed
the
master-proxmox-vm
branch
from
October 18, 2019 20:41
e3d34cc
to
f010c57
Compare
Is |
waynew
added
the
Needs-Testcase
PR needs test cases written, or the issue is about a bug/feature that needs test cases
label
Dec 3, 2019
Akm0d
changed the title
Tidy up pep8 issues
Modify the proxmox VM when using clone in the salt-cloud profile if settings are present
Dec 11, 2019
re-run full all |
re-run full m2crypto |
- Refactored proxmox clone reconfigure - Refactored helper functions
Akm0d
removed
the
Needs-Testcase
PR needs test cases written, or the issue is about a bug/feature that needs test cases
label
Jan 7, 2020
waynew
approved these changes
Jan 7, 2020
dwoz
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Port #49256 to master