Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cron.py): fix cron.identifier_exists => cron.get_entry #55007

Closed
wants to merge 2 commits into from
Closed

docs(cron.py): fix cron.identifier_exists => cron.get_entry #55007

wants to merge 2 commits into from

Conversation

myii
Copy link
Contributor

@myii myii commented Oct 14, 2019

What does this PR do?

Documentation change only.

'cron.identifier_exists' is not available.

Running the same with cron.get_entry works fine.

Commits signed with GPG?

Yes.

@myii
docs(cron.py): fix cron.identifier_exists => cron.get_entry
bff503b 
```bash
'cron.identifier_exists' is not available.
```

Running the same with `cron.get_entry` works fine.
@myii myii requested a review from a team as a code owner October 14, 2019 15:29
@ghost ghost requested a review from dwoz October 14, 2019 15:29
@myii
Copy link
Contributor Author

myii commented Oct 14, 2019

Caught a typo in master.py, added a commit for that as well.

waynew
waynew approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix

@dwoz dwoz changed the base branch from develop to master October 18, 2019 14:57
@dwoz dwoz changed the base branch from master to develop October 18, 2019 14:57
@dwoz
Copy link
Contributor

dwoz commented Nov 13, 2019

@myii can you rebase this to the master branch please?

@myii
Copy link
Contributor Author

myii commented Nov 13, 2019

@dwoz The main commit here depends on the merge of #52441 into master.

@dwoz
Copy link
Contributor

dwoz commented Nov 14, 2019

@myii We are no longer accepting PRs to the develop branch. This needs to be re-opened against the master branch. Sorry for the confusion.

@dwoz dwoz closed this Nov 14, 2019
@myii
Copy link
Contributor Author

myii commented Nov 14, 2019

@dwoz There's no confusion, this can be rebased on master but it doesn't exist there yet. In fact, the relevant master-port is #54985.

@myii myii mentioned this pull request Dec 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynew waynew waynew approved these changes

@dwoz dwoz Awaiting requested review from dwoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myii @dwoz @waynew