Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #51758 to master #54575

Closed
wants to merge 2 commits into from
Closed

[master] Porting #51758 to master #54575

wants to merge 2 commits into from

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 19, 2019 •
edited
Loading

Porting #51758 to master

@garethgreenaway garethgreenaway requested a review from a team September 19, 2019 00:04
@ghost ghost requested review from Akm0d and removed request for a team September 19, 2019 00:04
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #51758 to 2019.2.1 [master] Porting #51758 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:53
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Oct 28, 2019
s0undt3ch
s0undt3ch approved these changes Oct 28, 2019
View reviewed changes
Copy link
Collaborator

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was pre tests requirements.
But it could use a unit-test...

@Akm0d Akm0d requested a review from a team as a code owner November 9, 2019 00:10
@theskabeater theskabeater mentioned this pull request Nov 21, 2019
Merged
@dwoz
Copy link
Contributor

dwoz commented Dec 3, 2019

#55400 merged with tests

@dwoz dwoz closed this Dec 3, 2019
@waynew waynew removed Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases master-port labels Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Akm0d Akm0d Awaiting requested review from Akm0d

Assignees

@Akm0d Akm0d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@garethgreenaway @dwoz @s0undt3ch @waynew @Akm0d