Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt state fixes #54196

Merged
merged 6 commits into from
Dec 14, 2019
Merged

virt state fixes #54196

merged 6 commits into from
Dec 14, 2019

Commits on Dec 13, 2019

  1. virt.network_define doesn't have vport as positional argument 

    virt.network_running state calls virt.network_define with vport as a
positional argument resulting in an error at runtime. Fix the state to
use the vport named argument instead.
    @cbosdo
    cbosdo committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    51443a1 View commit details
    Browse the repository at this point in the history

  2. Fix virt.pool_running state documentation 

    virt.pool_running needs the source to be a dictionary, which the
documentation was not reflecting. Along the same lines the source hosts
need to be a list, adjust the example to show it.
    @cbosdo
    cbosdo committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a7414f5 View commit details
    Browse the repository at this point in the history

  3. Get virt.pool_running to start the pool after creating it 

    Commit 25b9681 is wrong in assuming the pool build also starts it. The
pool needs to be stopped before building it, but we still need to start
it after the build: libvirt won't do it automagically for us.
    @cbosdo
    cbosdo committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    547f827 View commit details
    Browse the repository at this point in the history

  4. Fix states to match virt.{network,pool}_infos return 

    virt.network_infos and virt.pool_infos return the infos as a dictionary
with the network or pool name as a key even when there is only one
value. Adapt the network_running and pool_running states to this.
    @cbosdo
    cbosdo committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    23a3fe5 View commit details
    Browse the repository at this point in the history

  5. Fix virt.running use of virt.vm_state 

    vm_state return a dictionary with the VM name as a key. Fix virt.running
state and its tests to match this. See issue saltstack#53107.
    @cbosdo
    cbosdo committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    8965d47 View commit details
    Browse the repository at this point in the history

  6. Fix virt states to not fail on VMs already stopped. 

    The virt.stopped and virt.powered_off states need to do nothing and
not fail if one of the targeted VMs is already in shutdown state.
    @cbosdo
    cbosdo committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    991ef2c View commit details
    Browse the repository at this point in the history