Fix csvpillar.py read file as binary #52747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynew
suggested changes
Apr 29, 2019
There was a problem hiding this comment.
Looks mostly great - a couple of lint issues from your tests file:
https://jenkinsci.saltstack.com/job/pr-lint/job/PR-52747/1/warnings52Result/new/
New commit pushed addressing linting |
waynew
approved these changes
Apr 30, 2019
|
When does this show up merged into the 2019.2 and develop branch? |
|
We're working on some better documentation on our merge forward process, but this should get picked up in the next merge forward from |
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Dec 24, 2019
[master] Porting #52747 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves an error in csvpillar.py (at least when run in Python 3) where it attempted to read csv files from disk in binary format.
What issues does this PR fix or reference?
#52538
Previous Behavior
csvpillar.py attempted to read csv files in binary format
New Behavior
csvpillar.py now reads csv files in text format
Tests written?
Yes
Commits signed with GPG?
No