[WIP][2019.2] Pillar refresh fixes #52377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddition to self.opts['pillar'].
…t into pillar_refresh_fixes
|
@garethgreenaway it's not finished yet. Am I right? |
|
@DmitryKuzmenko just not sure if my approach is 100% correct. |
|
I don't see how it could help. Is the |
|
@DmitryKuzmenko |
|
@garethgreenaway ping! Does this PR make any sense now? |
|
@garethgreenaway want to rebase this against |
dmurphy18
requested changes
May 25, 2021
|
I wonder if this still needed |
|
@garethgreenaway is this still needed or can it be closed? |
|
@Ch3LL Looks like another PR fixed the issue. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
__pillar__in addition to self.opts['pillar'] when a state run happens.What issues does this PR fix or reference?
#52354
Previous Behavior
During a state run if a pillar error occurred it would be preserved in
__pillar__, so on subsequent state runs during the error checking the run would be flagged as having an error even if the issue has been corrected.New Behavior
When self.opts['pillar'] is updated, update
__pillar__as well.Tests written?
No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.