cmd: Add root parameter for wait and run states #50302

aplanas · 2018-10-30T09:52:47Z

What does this PR do?

Add root parameter for a chroot environment to wait and run
states. In the case of run, we delegate the execution to the
run_chroot module.

salt/states/cmd.py

Add root parameter for a chroot environment to `wait` and `run` states. In the case of `run`, we delegate the execution to the `run_chroot` module.

saltstack/salt#49668 saltstack/salt#49669 saltstack/salt#49670 saltstack/salt#49803 saltstack/salt#49804 saltstack/salt#50126 saltstack/salt#50175 saltstack/salt#50302 saltstack/salt#50380 saltstack/salt#50396 saltstack/salt#50418 saltstack/salt#50452 saltstack/salt#50473 saltstack/salt#50541 saltstack/salt#50607 saltstack/salt#50635 saltstack/salt#50671 saltstack/salt#50706 saltstack/salt#50725 saltstack/salt#50801 saltstack/salt#50834 saltstack/salt#51074 saltstack/salt#51094 saltstack/salt#51135

* blockdev: fix url from comment saltstack/salt#49668 * Documentation: fix typo in "equivalent" saltstack/salt#49669 * states_pt3: fix rST link format saltstack/salt#49670 * parted: fix _validate_partition_boundary saltstack/salt#49803 * parted: fix the ordering of list command saltstack/salt#49804 * Fix lowpkg.diff documentation and parameter name saltstack/salt#50126 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * service: SUSE is not based on sysvinit anymore saltstack/salt#50396 * Add new chroot module saltstack/salt#50418 * Add new module freezer saltstack/salt#50452 * parted: support variable length output for print saltstack/salt#50473 * btrfs: add all subvolume commands saltstack/salt#50541 * file: update attributes for lsattr and chattr saltstack/salt#50607 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default saltstack/salt#50801 * Add disk_set and disk_toggle functions, and update valid partition flags saltstack/salt#50834 * disk: support setting FAT size for format_ saltstack/salt#51074 * cmdmod: add sysfs into the chroot saltstack/salt#51094 * mount: cache blkid information saltstack/salt#51135

* Add root and no_recommends parameters in the public interface for Zypper and RPM (lowpkg) saltstack/salt#50125 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * Add new chroot module https://github.com/openSUSE/salt/pull/50418 * Add new module freezer saltstack/salt#50452 * btrfs: add all subvolume commands saltstack/salt#50541 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default https://github.com/openSUSE/salt/pull/50801 * Add disk_set and disk_toggle functions, and update valid partition flags https://github.com/openSUSE/salt/pull/50834 * disk: support setting FAT size for format_ https://github.com/openSUSE/salt/pull/51074 * parted: fix set_ valid flags comment. https://github.com/openSUSE/salt/pull/51704 * grains/core: ignore HOST_NOT_FOUND errno in fqdns() https://github.com/openSUSE/salt/pull/51706 * cmdmod: add 'binds' parameter in run_chroot https://github.com/openSUSE/salt/pull/51871 * mount: fix extra -t parameter https://github.com/openSUSE/salt/pull/51905 * lvm: be quiet when a pv, lv or vg is not expected https://github.com/openSUSE/salt/pull/51929 * linux_lvm: clean error in pvcreate and pvremove https://github.com/openSUSE/salt/pull/51954 * blockdev: hide blkid errors when are expected https://github.com/openSUSE/salt/pull/51956 * partially unify public functions signature for pkg and lowpkg https://github.com/openSUSE/salt/pull/51973 * extmods: add utils directories in sys.path https://github.com/openSUSE/salt/pull/52001

* Add root and no_recommends parameters in the public interface for Zypper and RPM (lowpkg) saltstack/salt#50125 * Add root parameter to useradd, shadow and groupadd saltstack/salt#50175 * cmd: Add root parameter for wait and run states saltstack/salt#50302 * systemd: add optional root parameter saltstack/salt#50380 * Add new chroot module https://github.com/openSUSE/salt/pull/50418 * Add new module freezer saltstack/salt#50452 * btrfs: add all subvolume commands saltstack/salt#50541 * btrfs: add new btrfs state saltstack/salt#50635 * zypper: demote log from error to warning saltstack/salt#50671 * blkid: add search by token saltstack/salt#50706 * mount: add fstab_{present,absent} states saltstack/salt#50725 * btrfs: add option to not set subvolumes as default saltstack/salt#50801 * Add disk_set and disk_toggle functions, and update valid partition flags saltstack/salt#50834 * disk: support setting FAT size for format_ saltstack/salt#51074 * parted: fix set_ valid flags comment. saltstack/salt#51704 * grains/core: ignore HOST_NOT_FOUND errno in fqdns() saltstack/salt#51706 * cmdmod: add 'binds' parameter in run_chroot saltstack/salt#51871 * mount: fix extra -t parameter saltstack/salt#51905 * lvm: be quiet when a pv, lv or vg is not expected saltstack/salt#51929 * linux_lvm: clean error in pvcreate and pvremove saltstack/salt#51954 * blockdev: hide blkid errors when are expected saltstack/salt#51956 * partially unify public functions signature for pkg and lowpkg saltstack/salt#51973 * extmods: add utils directories in sys.path saltstack/salt#52001

aplanas force-pushed the fix_chroot branch 6 times, most recently from f87591b to 8c000ef Compare October 31, 2018 15:59

cachedout reviewed Oct 31, 2018

View reviewed changes

salt/states/cmd.py Show resolved Hide resolved

cmd: Add root parameter for wait and run states

cd7b5b2

Add root parameter for a chroot environment to `wait` and `run` states. In the case of `run`, we delegate the execution to the `run_chroot` module.

aplanas force-pushed the fix_chroot branch from 9e1f2d4 to cd7b5b2 Compare October 31, 2018 19:36

cachedout approved these changes Nov 1, 2018

View reviewed changes

Merge branch 'develop' into fix_chroot

277dffd

rallytime merged commit cf84565 into saltstack:develop Nov 1, 2018

aplanas deleted the fix_chroot branch November 5, 2018 08:41

aplanas mentioned this pull request Jan 30, 2019

Backport from develop features required by yomi openSUSE/salt#120

Closed

garethgreenaway added a commit to garethgreenaway/salt that referenced this pull request Sep 19, 2019

Porting PR saltstack#50302 to 2019.2.1

597e4f3

garethgreenaway mentioned this pull request Sep 19, 2019

[master] Porting #50302 to master #54614

Closed

aplanas mentioned this pull request Oct 11, 2019

(Backport 50302) cmd: Add root parameter for wait and run states #54956

Merged

waynew added the has master-port port to master has been created label Dec 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd: Add root parameter for wait and run states #50302

cmd: Add root parameter for wait and run states #50302

aplanas commented Oct 30, 2018

cmd: Add root parameter for wait and run states #50302

cmd: Add root parameter for wait and run states #50302

Conversation

aplanas commented Oct 30, 2018

What does this PR do?