Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AWS SSM parameter module #50215

Merged
merged 2 commits into from
Oct 25, 2018
Merged

New AWS SSM parameter module #50215

merged 2 commits into from
Oct 25, 2018

Conversation

mchugh19
Copy link
Contributor

@mchugh19 mchugh19 commented Oct 24, 2018

What does this PR do?

Creates new module to set/get/put secrets in AWS SSM parameters
@blade2005 @rv-ptighe

What issues does this PR fix or reference?

#46510

New Behavior

# salt-call boto_ssm.put_parameter test-first test_value1 Type=SecureString KeyId=alias/aws/ssm Description='test encrypted key'
local
    1

# salt-call boto_ssm.get_parameter test-first withdecryption=True
local:
    test_value

# salt-call boto_ssm.delete_parameter test-first
local:
    True

Tests written?

No

Todo:

  • tests
  • sdb?

@ghost ghost self-requested a review October 24, 2018 22:22
Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see this used to make an sdb module.

Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rallytime
Copy link
Contributor

@mchugh19 There's a merge conflict in the release notes file. Can you fix that up? Then we should be able to get this in. :)

@cachedout
Copy link
Contributor

I went ahead and resolved the conflict and this is ready for merge.

@cachedout cachedout merged commit ececa7a into saltstack:develop Oct 25, 2018
@mchugh19 mchugh19 deleted the ssm branch July 4, 2019 14:23
mchugh19 pushed a commit to mchugh19/salt that referenced this pull request Oct 13, 2019
@waynew waynew added the has master-port port to master has been created label Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has master-port port to master has been created
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants