[develop] Initial work to allow running multiple instances of a Salt engine #50059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify, this is for running multiple instances of the same engine, yes? |
|
@cachedout exactly. |
rares-pop
reviewed
Oct 19, 2018
salt/engines/__init__.py
Outdated
| @@ -46,10 +46,22 @@ def start_engines(opts, proc_mgr, proxy=None): | |||
| engine, engine_opts = next(iter(engine.items())) | |||
| else: | |||
| engine_opts = None | |||
| fun = '{0}.start'.format(engine) | |||
| engine_name = None | |||
| if engine_opts is not None and 'type' in engine_opts: | |||
There was a problem hiding this comment.
where is that 'type' coming from? It's a new configuration for an engine?
There was a problem hiding this comment.
type would be a new configuration option in the engine configuration, so it would contain strings like slack or script depending on what type of engine the particular stanza in the configuration would be providing.
garethgreenaway
force-pushed
the
allow_multiple_engine_instances
branch
2 times, most recently
from
f56f5e2
to
ec75a3c
Compare
garethgreenaway
changed the title
…ut new engine_type parameter
garethgreenaway
force-pushed
the
allow_multiple_engine_instances
branch
from
0c3bd91
to
d84993b
Compare
|
@rares-pop How does this look to you now? |
|
@rallytime - it looks good! It adds a very nice functionality. I like 'engine_module' better than the previously 'type'. Good job @garethgreenaway! |
rares-pop
approved these changes
Oct 30, 2018
dwoz
added a commit
that referenced
this pull request
Jan 13, 2020
[master] Porting #50059 to master
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Initial work to allow running multiple instances of a Salt engine
What issues does this PR fix or reference?
N/A
Tests written?
Yes.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.