fixing mis-spelling of lattrs in file.py, referncing #49204 #49827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtmanfred
approved these changes
Sep 28, 2018
|
great catch! |
|
happy to help ! |
rallytime
added
the
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per request from @gtmanfred, creating a pull request
What does this PR do?
Correct the mis-spelling of lattrs in the except block, line 4514
What issues does this PR fix or reference?
when running a file action that recurses (e.g. recurse owner, group, mode, etc), the state would fail. Found this issue in 2018.1 and discovered that it was being fixed in latest develop branch.
lattrs is mis-spelled in this line. if the except condition fires, then the following
if lattrs is not None:line will throw anlocal variable 'lattrs' referenced before assignmenterror.Previous Behavior
local variable 'lattrs' referenced before assignmenterrorTests written?
No
Commits signed with GPG?
No