Bugfix/rework: IPv6 scope errors (bp) #49815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 28, 2018 15:22
This cannot be detected with type comparison, because bytes == str and at the same time bytes != str if compatibility is not around
ghost
requested review from
isbm
changed the title
terminalmage
approved these changes
Sep 28, 2018
gtmanfred
approved these changes
Sep 28, 2018
DmitryKuzmenko
suggested changes
Sep 28, 2018
tests/unit/modules/test_network.py
Outdated
| @@ -276,7 +267,7 @@ def test_connect(self): | |||
| self.assertDictEqual(network.connect('host', 'port'), | |||
| {'comment': ret, 'result': True}) | |||
|
|
|||
| @skipIf(HAS_IPADDRESS is False, 'unable to import \'ipaddress\'') | |||
| @skipIf(bool(ipaddress), 'unable to import \'ipaddress\'') | |||
There was a problem hiding this comment.
@skipIf(not ipaddress, ...?
tests/unit/modules/test_network.py
Outdated
| @@ -288,7 +279,7 @@ def test_is_private(self): | |||
| return_value=True): | |||
| self.assertTrue(network.is_private('::1')) | |||
|
|
|||
| @skipIf(HAS_IPADDRESS is False, 'unable to import \'ipaddress\'') | |||
| @skipIf(bool(ipaddress), 'unable to import \'ipaddress\'') | |||
There was a problem hiding this comment.
@skipIf(not ipaddress, ...?
meaksh
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-to-one (almost) backport of bugfix, available at #49705