publish.publish trim mods after comma split #49634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
brejoc
approved these changes
Sep 14, 2018
dwoz
approved these changes
Sep 16, 2018
dwoz
reviewed
Sep 16, 2018
isbm
suggested changes
Sep 28, 2018
|
Had to forgo filter method due to linter reporting invalid code for python3 |
rallytime
approved these changes
Oct 4, 2018
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
saltybaker
pushed a commit
to saltybaker/salt
that referenced
this pull request
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug I found when applying states via publish.publish.
salt['publish.publish'](......fun='state.apply', arg='["mods=state1.latest,state2.latest"]'...)
If the mods inside the arg contains spaces, the process will fail.
What issues does this PR fix or reference?
Did not open a bug report.
Previous Behavior
Salt publish.publish fails if the mods inside arg contains white spaces after the comma split.
This Fails: "state1.latest, state2.latest"
New Behavior
Salt publish.publish works as expected since the state names are now trimmed.
This now works: "state1.latest, state2.latest"
Also generalized the trim for other mods splits
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.