Minor error message improvement and documentation fix #42254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected property name in documentation. Updated library version dependency.
|
@edevenport, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rallytime, @techhat and @s0undt3ch to be potential reviewers. |
edevenport
changed the title
cachedout
suggested changes
Jul 17, 2017
| @@ -6,7 +6,7 @@ | |||
| The ProfitBricks SaltStack cloud module allows a ProfitBricks server to | |||
| be automatically deployed and bootstraped with Salt. | |||
|
|
|||
| :depends: profitbrick >= 3.0.0 | |||
| :depends: profitbrick >= 3.1.0 | |||
There was a problem hiding this comment.
Please document this change in the Oxygen release notes: https://github.com/saltstack/salt/blob/develop/doc/topics/releases/oxygen.rst
cachedout
pushed a commit
to cachedout/salt
that referenced
this pull request
Jul 25, 2017
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jul 26, 2017
* upstream/develop: (24 commits) Remove deprecated rc_info function from version.py Document change in saltstack#42254 Added release notes comment Syntax change Logical Domains support in virtual grain Add support for IDMS Linux win_pki: Don't fail on certs without DnsNames Fix tests saltstack#2 zypper.list_pkgs: add all option for attr zypper.list_pkgs: move attr parameter to kwargs zypper.list_pkgs: add install_time_date_t as a supported attribute zypper_test: add test for list_pkgs and attr zypper_test: adapt existing unit tests to new code zypper_test: correct mock behavior zypper.list_pkgs: add documentation for attr param zypper.list_pkgs: add attr option Fixed test Fixed pylint Move parse_docstring from salt.utils to salt.utils.doc.py Added tests for salt.modules.vsphere.create_datacenter ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
Tests written?
No