Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #20497 to 2015.2 #21863

Merged
merged 5 commits into from
Mar 21, 2015
Merged

Backport #20497 to 2015.2 #21863

merged 5 commits into from
Mar 21, 2015

Conversation

rallytime
Copy link
Contributor

Backport #20497 to 2015.2

@thatch45
Copy link
Contributor

Go Go Jenkins!

highlyunavailable and others added 5 commits March 20, 2015 16:26
Some influxdb python API methods changed names and were generating
warnings every time this module was run.

The user_remove method had a bug that actually deleted the user you were
logged in as rather than the user you wanted to delete when run.

Added a method to test login for a user to see if they exist (mostly to
work around a use case described in saltstack#20496.) - for example to try logging
in as root:root to see if it's been deleted.
That'll teach me not to work in two places at once.
@rallytime
Copy link
Contributor Author

I think something funny is happening with the branch. I've rebased to try again.

@steverweber
Copy link
Contributor

ref to close when merged.
#21860

I'll also do some testing to ensure this is a good direction. cheers

jfindlay added a commit that referenced this pull request Mar 21, 2015
@jfindlay jfindlay merged commit 466e11a into saltstack:2015.2 Mar 21, 2015
@steverweber
Copy link
Contributor

sadly im going to request a revert here... the influxdb python lib is not ready for the new version of influxdb and this back-port will likely cause more harm than good at this time.

once the developer has these issues checked off...
influxdata/influxdb-python#109

this influxdb module can be updated.
Sorry for the lost cycles.

@rallytime rallytime deleted the bp-20497 branch March 24, 2015 16:07
@cp-richard
Copy link

Not sure if influxdata/influxdb-python#109 is being updated - ie issue 108 has been fixed. The readme states that 0.9 is the recommended version now.

update.. while influxdb-python looks ready for 0.9+, there is a lot more work needed in the salt module than just the list and switch functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants