Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Device mapper names not parsed properly #64082

Closed
sean-anderson-seco opened this issue Apr 14, 2023 · 2 comments · Fixed by #64161
Closed

[BUG] Device mapper names not parsed properly #64082

sean-anderson-seco opened this issue Apr 14, 2023 · 2 comments · Fixed by #64161
Assignees
Labels
Bug broken, incorrect, or confusing behavior needs-triage

Comments

@sean-anderson-seco
Copy link

Description

Device mapper names such as dm_crypt-0 (the default format for Ubuntu Server) are not parsed properly by cryptdev.list. This is because device mapper names may include non-"word" characters such as dashes. This confuses the regex. Instead, we should match based on non-space and space characters instead (such as what is done by sean-anderson-seco/salt@6471623). I would submit this as a PR, but there are no tests for this module and I don't want to create them.

Steps to Reproduce the behavior

truncate -s 64M /tmp/dummy
echo | sudo cryptsetup luksFormat /tmp/dummy
echo | sudo cryptsetup open /tmp/dummy my-device
sudo salt-call cryptdev.active

Expected behavior

The device should be listed properly.

Versions Report

3005.1. I have verified by inspection that this issue exists in master.

@sean-anderson-seco sean-anderson-seco added Bug broken, incorrect, or confusing behavior needs-triage labels Apr 14, 2023
@welcome
Copy link

welcome bot commented Apr 14, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@anilsil anilsil added this to the Sulfur v3006.1 milestone Apr 18, 2023
@whytewolf whytewolf linked a pull request Apr 26, 2023 that will close this issue
3 tasks
s0undt3ch pushed a commit that referenced this issue Apr 26, 2023
@whytewolf
Copy link
Collaborator

closing as #64161 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants