-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Add diff_attr
to pkg.upgrade()
(At least for Yum, Zypper, Apt)
#62031
Labels
Comments
agraul
added
Feature
new functionality including changes to functionality and code refactors, etc.
needs-triage
labels
May 6, 2022
Merged
3 tasks
agraul
added a commit
to openSUSE/salt
that referenced
this issue
Jun 14, 2022
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
tiltingpenguin
added a commit
to openSUSE/salt
that referenced
this issue
Jul 6, 2022
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031
tiltingpenguin
added a commit
to openSUSE/salt
that referenced
this issue
Jul 6, 2022
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Jul 7, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
tiltingpenguin
added a commit
to openSUSE/salt
that referenced
this issue
Jul 7, 2022
…ade()/yumpkg.upgrade() - backport 3000 (#545) * Add names and pkgs parameters to zypper.upgrade * Don't turn attr="all" into a list * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031
tiltingpenguin
added a commit
to openSUSE/salt
that referenced
this issue
Jul 7, 2022
…ade()/yumpkg.upgrade() - backport 3000.3 (#544) * Add names and pkgs parameters to zypper.upgrade * Don't turn attr="all" into a list * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031
agraul
added a commit
to agraul/salt
that referenced
this issue
Oct 6, 2022
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack#62031
Ch3LL
pushed a commit
that referenced
this issue
Oct 6, 2022
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: #62031
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Dec 28, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Dec 28, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
meaksh
pushed a commit
to openSUSE/salt
that referenced
this issue
Dec 29, 2022
…ade()/yumpkg.upgrade() - backport 3004 (#538) * Migrate zypper.upgrade tests to pytest (cherry picked from commit ecce005b543f66198c7ac118966254dd3d60682f) * Add names and pkgs parameters to zypper.upgrade Fixes saltstack/salt#62030 (cherry picked from commit 19ebb40dc4538c983721a8746a201b7f1300c2f7) * Don't turn attr="all" into a list pkg_resource.format_pkg_list expects its `attr` argument to be either a list of attributes or the string "all" to indicate all available attributes should be used for formatting. Fixes: saltstack/salt#62032 (cherry picked from commit 05482da89b91442235d3cc2889e59ac3722a7fae) * Add diff_attr parameter to zypper/yum upgrade diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031 (cherry picked from commit 20ffffe3be6c7d94e9cc3338a57bbf5014f33d93)
blu-base
pushed a commit
to blu-base/saltext-zypper
that referenced
this issue
Nov 2, 2024
diff_attr works just like it does for pkg.install. Having the option to return additional attributes can remove the need for a follow-up list_pkgs call. Fixes: saltstack/salt#62031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your feature request related to a problem? Please describe.
pkg.upgrade()
only provides limited information of packages that changed, whilepkg.install()
can, optionally, provide more information. The additional information can also be gathered bypkg.list_pkgs(attr=X)
whereX
is a list of attributes or the string "all", but that requires an additional function call.Describe the solution you'd like
Just like
pkg.install(..., diff_attr=X)
,pkg.upgrade(..., diff_attr=X)
returns the specified attributes in addition to the name and the version.Describe alternatives you've considered
Since this addition is very small and already exists in
pkg.install()
, I haven't considered alternatives to addingdiff_attr
topkg.upgrade()
. I'm not aware of any downside except for having another parameter inpkg.upgrade()
.The text was updated successfully, but these errors were encountered: