Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT] remove get_event's transport argument #61275

Closed
dwoz opened this issue Nov 20, 2021 · 2 comments · Fixed by #61388
Closed

[TECH DEBT] remove get_event's transport argument #61275

dwoz opened this issue Nov 20, 2021 · 2 comments · Fixed by #61388
Assignees
@MKLeb
Labels
Deprecation Phosphorus v3005.0 Release code name and version tech-debt
Milestone
Phosphorus v3005.0

Comments

@dwoz
Copy link
Contributor

dwoz commented Nov 20, 2021

salt.utils.event.get_event takes a transport argument that never gets used. Remove this argument and make sure it's not being passed in anywhere.
@dwoz dwoz added the tech-debt label Nov 20, 2021
@dwoz dwoz changed the title [TECH DEBT] [TECH DEBT] remove get_event's transport argument Nov 20, 2021
@dwoz dwoz removed the tech-debt label Nov 20, 2021
@dwoz dwoz assigned MKLeb and unassigned dwoz Nov 20, 2021
@dwoz dwoz mentioned this issue Nov 20, 2021
Closed
3 tasks
@MKLeb
Copy link
Contributor

MKLeb commented Nov 20, 2021 •
edited
Loading

@dwoz Will look into this after Thanksgiving, bandwidth is full for this upcoming week.

@MKLeb
Copy link
Contributor

MKLeb commented Dec 22, 2021 •
edited
Loading

A few questions...

  1. Does this require some sort of deprecation notice? I have seen uses of this method outside of salt (eg. salt extensions) that use the transport kwarg.
  2. What kind of tests would be relevant for this?

@MKLeb MKLeb mentioned this issue Dec 22, 2021
Merged
3 tasks
@MKLeb MKLeb mentioned this issue Jan 6, 2022
Merged
@MKLeb MKLeb added Deprecation Phosphorus v3005.0 Release code name and version labels Jan 20, 2022
@MKLeb MKLeb added this to the Phosphorus v3005.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MKLeb MKLeb

Labels
Deprecation Phosphorus v3005.0 Release code name and version tech-debt
Projects
None yet
Milestone
Phosphorus v3005.0
Development

Successfully merging a pull request may close this issue.

Remove 'transport' kwarg fom 'salt.utils.event.get_event' MKLeb/salt
2 participants
@dwoz @MKLeb