Skip to content

Commit

Permalink
Merge pull request #54642 from garethgreenaway/2019_2_1_port_50938
Browse files Browse the repository at this point in the history
[master] Porting #50938 to master
  • Loading branch information
dwoz authored Dec 29, 2019
2 parents fd4395e + 774015d commit 312b75b
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
18 changes: 18 additions & 0 deletions salt/modules/opkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -1462,3 +1462,21 @@ def owner(*paths, **kwargs): # pylint: disable=unused-argument
if len(ret) == 1:
return next(six.itervalues(ret))
return ret


def version_clean(version):
'''
Clean the version string removing extra data.
There's nothing do to here for nipkg.py, therefore it will always
return the given version.
'''
return version


def check_extra_requirements(pkgname, pkgver):
'''
Check if the installed package already has the given requirements.
There's nothing do to here for nipkg.py, therefore it will always
return True.
'''
return True
12 changes: 12 additions & 0 deletions tests/unit/modules/test_opkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,15 @@ def test_info_installed(self):
mock = MagicMock(return_value=ret_value)
with patch.dict(opkg.__salt__, {'cmd.run_all': mock}):
self.assertEqual(opkg.info_installed('vim'), expected_dict)

def test_version_clean(self):
'''
Test - Return the information of version_clean
'''
self.assertEqual(opkg.version_clean('1.0.1'), '1.0.1')

def test_check_extra_requirements(self):
'''
Test - Return the information of check_extra_requirements
'''
self.assertEqual(opkg.check_extra_requirements('vim', '1.0.1'), True)

0 comments on commit 312b75b

Please sign in to comment.