Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login method broke #116

Closed
chewvader opened this issue Feb 17, 2018 · 2 comments
Closed

Login method broke #116

chewvader opened this issue Feb 17, 2018 · 2 comments
Labels
Milestone

Comments

@chewvader
Copy link

Looks like the login method changed in the 0.5.3 update, and broke a number scripts for me.
5508c6c?diff=split

returned exception: login() takes exactly 1 argument (4 given)

The docstring still lists the old login method parameters:
https://github.com/saltstack/pepper/blob/develop/pepper/libpepper.py#L38

For a patch version number update, can we make this change in a backwards compatible fashion?

@gtmanfred gtmanfred added the bug label Feb 27, 2018
@gtmanfred gtmanfred added this to the Approved milestone Feb 27, 2018
@gtmanfred
Copy link
Contributor

Whoops, yeah that needs to be fixed.

gtmanfred added a commit that referenced this issue Mar 1, 2018
@gtmanfred
Copy link
Contributor

https://github.com/saltstack/pepper/releases/tag/0.5.4

Fixed, thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants