Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade salt-lint release #127

Closed

Conversation

sylvainfaivre
Copy link
Contributor

@sylvainfaivre sylvainfaivre commented Nov 27, 2023

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

  • [chore]

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Fixes this error in the pre-commit :

              error in salt-lint setup command: 'python_requires' must be a string containing valid version specifiers; Invalid specifier: '>=3.6.*'

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@sylvainfaivre sylvainfaivre requested a review from a team as a code owner November 27, 2023 17:20
@jeff350
Copy link
Contributor

jeff350 commented Nov 28, 2023

@sylvainfaivre Can you please make this a "chore" instead of a "fix" and I will get this merged in. The fix will cause a new release to be created while a chore does not. With this only affecting CI testing and not the actual formula there is no need for a new release.

@jeff350 jeff350 self-requested a review November 28, 2023 14:50
@sylvainfaivre sylvainfaivre changed the title fix: upgrade salt-lint release chore: upgrade salt-lint release Nov 28, 2023
@sylvainfaivre
Copy link
Contributor Author

replaced by #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants