fix(package): use correct version parameter with packages #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierbertoli
force-pushed
the
fix-version-usage-on-package-install
branch
2 times, most recently
from
b6fe4a3
to
c3bd2ce
Compare
javierbertoli
force-pushed
the
fix-version-usage-on-package-install
branch
from
397fed8
to
a5cdd41
Compare
* fix(package): remove double colon preventing correct version usage * feat(package): when `use_upstream_repo: true`, guess URL's version from `node:version`'s major value, to be consistent where the major version is obtained from. This also allows to pick a minor version from the repo (if available), using `node:pkg:version` * feat(version): update to latest LTS node version (16.13.0) BREAKING CHANGE: `node:pkg:version` needs to be specified as the full version number (ie, 16.13.0) instead of just the major number in order to be able to properly install using packages and pin the desired version.
javierbertoli
force-pushed
the
fix-version-usage-on-package-install
branch
from
a5cdd41
to
6ce8259
Compare
|
Performing "selfie-merge" for this PR, in line with community conventions:- https://github.com/saltstack/salt/blob/develop/doc/topics/development/conventions/formulas.rst#get-involved-creating-new-formulas |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
This should fix #54
Describe the changes you're proposing
When installing using
packages(the default),node:pkg:versionis used to pin the package. But there was a typothat caused the issue described in #54. Fixed it.
Also, the formula uses
node:version(defaulting to13.12.0) as the complete version of the package to install when using source or archive installs, butnode:pkg:versionas the package to pin the version when installing usingpackages, but taken directly from pillars.node:pkg:versionto set the version in the upstream url for the repos, defaulting to only the major part of theversion (
node:pkg:version: '14'indefaults.yaml)This results in errors when installing using
use_upstream_repo: true, as:This PR fixes all the above, by:
node:pkg:versioncorrectly when pinningnode:versionto set the upstream's url when settinguse_upstream_repo: true(ugly, but better than the current situation)As a side effect, to fix the tests, updated the version to current upstream's version (17.0.1)
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context