Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.sls to disable sorting #120

Closed
wants to merge 1 commit into from

Conversation

lingonl
Copy link

@lingonl lingonl commented May 26, 2016

Adding sort_keys=False to json() allows nginx.server.config to be sorted as needed for the resulting config file to work with access_log+log_format (issue #102 ) and other parameters (issue #40)

Adding sort_keys=False to json() allows nginx.server.config to be sorted as needed for the resulting config file to work with access_log+log_format (issue saltstack-formulas#102) and other parameters (issue saltstack-formulas#40)
@lingonl lingonl closed this May 26, 2016
@lingonl lingonl reopened this May 26, 2016
@lingonl lingonl closed this May 27, 2016
@gravyboat
Copy link
Contributor

Did you mean to close this? I know the current work around is kind of dirty, but does this catch all the edge cases?

@lingonl
Copy link
Author

lingonl commented May 27, 2016

The fix didn't work, sorry. The order was ok for my config but gets shuffled somewhere else and is still unpredictable. I'll work on a fix after the weekend, maybe the same way the postfix formula works (more explicit with the ordering/options).

Groet,

Joost de Mes

On 27 mei 2016, at 20:28, Forrest [email protected] wrote:

Did you mean to close this? I know the current work around is kind of dirty, but does this catch all the edge cases?


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

@lingonl lingonl deleted the patch-1 branch May 31, 2016 12:48
@ernstae
Copy link

ernstae commented Feb 5, 2017

I get this error:
nginx: [emerg] "load_module" directive is specified too late in /etc/nginx/modules-enabled/50-mod-http-auth-pam.conf:1

When I add this to my pillar:

nginx:
  ng:
    config:
      include:
        - '/etc/nginx/modules-enabled/*.conf'

The resulting nginx.conf has this line too far below my vhosts definitions, which are attempting to use TCP stream proxying.

I changed my config.sls file to use sort_keys=False on the json() call, but that didn't resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants