Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Promote ng version #34

Closed
n-rodriguez opened this issue Oct 9, 2019 · 5 comments · Fixed by #40
Closed

[FEATURE] Promote ng version #34

n-rodriguez opened this issue Oct 9, 2019 · 5 comments · Fixed by #40

Comments

@n-rodriguez
Copy link
Member

It could be nice to promote the ng version of this formula.

@myii
Copy link
Member

myii commented Oct 9, 2019

Sounds good. We'd need to go through the same steps as when we promoted other ng formulas.

@myii
Copy link
Member

myii commented Oct 9, 2019

saltstack-formulas/template-formula#21 has links to previous conversions.

@daks
Copy link
Member

daks commented Oct 9, 2019

+1 for promoting ng and doing deprecation steps

@myii
Copy link
Member

myii commented Oct 9, 2019

To be more helpful, it's the section:

Those PRs are in the order of things to be done. I'm not sure but maybe one of them had multiple steps involved.

myii pushed a commit to myii/ssf-formula that referenced this issue Nov 27, 2019
# [1.64.0](v1.63.0...v1.64.0) (2019-11-27)

### Features

* **fail2ban:** add notification about upcoming `ng` promotion ([8c91168](8c91168)), closes [/github.com/saltstack-formulas/fail2ban-formula/issues/34#issuecomment-539986988](https://github.com//github.com/saltstack-formulas/fail2ban-formula/issues/34/issues/issuecomment-539986988)
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
@myii myii mentioned this issue Jan 11, 2020
19 tasks
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
* Close saltstack-formulas#34
* Close saltstack-formulas#35

BREAKING CHANGE: all previous `fail2ban` based configurations must be
reviewed; `fail2ban.ng` usage must be promoted to `fail2ban` and any
uses of the original `fail2ban` will have to be converted.
myii added a commit to myii/fail2ban-formula that referenced this issue Jan 11, 2020
* Semi-automated using myii/ssf-formula#119
* Close saltstack-formulas#34
* Close saltstack-formulas#35

BREAKING CHANGE: all previous `fail2ban` based configurations must be
reviewed; `fail2ban.ng` usage must be promoted to `fail2ban` and any
uses of the original `fail2ban` will have to be converted.
saltstack-formulas-travis pushed a commit that referenced this issue Jan 13, 2020
# [1.0.0](v0.17.2...v1.0.0) (2020-01-13)

### Features

* promote `ng` ([fb1ae56](fb1ae56)), closes [#34](#34) [#35](#35)

### BREAKING CHANGES

* all previous `fail2ban` based configurations must be
reviewed; `fail2ban.ng` usage must be promoted to `fail2ban` and any
uses of the original `fail2ban` will have to be converted.
@saltstack-formulas-travis

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants