fix(syntax): param 'refresh' replaces 'refresh_db'

[noelmcloughlin]

Fix this

[WARNING ] /usr/lib/python3/dist-packages/salt/states/pkgrepo.py:313: 
DeprecationWarning: The 'refresh_db' argument to 'pkg.mod_repo' has 
been renamed to 'refresh'. Support for using 'refresh_db' will 
be removed in the Neon release of Salt.

[myii]

@noelmcloughlin Will we still need refresh_db for the previous versions of Salt that we're still supporting (back to 2017.7 at the time of this comment)? I.e. Does it need to be conditional?

[noelmcloughlin]

I.e. Does it need to be conditional?

No, its supported in 2017.8
https://docs.saltstack.com/en/2017.7/ref/states/all/salt.states.pkg.html#salt.states.pkg.installed

[myii]

@noelmcloughlin The error message above mentions pkg.mod_repo (module), not pkg.installed (state). Looking a bit deeper, it appears that the introduction of refresh (in place of refresh_db) goes back as far as 2018.2:

• saltstack/salt@999aa63

So this change will need to be tested on 2017.7.

[noelmcloughlin]

Let me check again. thanks.

[noelmcloughlin]

Good catch myii. refresh_db is "Deprecated since version 2018.3.0: Use refresh instead."

I'll update commit with a conditional.

[myii]

Merged, thanks @noelmcloughlin.