Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/semantic release #23

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Docs/semantic release #23

merged 2 commits into from
Apr 28, 2019

Conversation

daks
Copy link
Member

@daks daks commented Apr 26, 2019 •
edited by myii
Loading

semantic-release implementation.

About existing tests, I adapted them to work with the new setups, without looking more deeply about the code used (states) or the tests themself.
I deactivated Fedora builds because they fail, and weren't tested before.

Update (from @myii):

  • Upgrade the CI matrix to use the pre-salted images -- the current run takes over 20 minutes (over 45 minutes of total time).
  • Update the README with the semantic-release badge and information, including the link to commit message formatting.

myii
myii reviewed Apr 26, 2019
View reviewed changes
.travis.yml Outdated

- INSTANCE: v2017-7-py2-debian-8
- INSTANCE: v2017-7-py2-ubuntu-1604
- INSTANCE: v2017-7-py2-bootstrap-centos-6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the new, pre-salted matrix here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What? Once again... sorry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new pre-salted matrix from the template-formula. Which was introduced with this PR: saltstack-formulas/template-formula#92.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daks I'm testing this right now anyway, so the commit is available (temporarily) in my branch:

This is currently running with Fedora, so let's see what happens with it:

myii
myii requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working well but just a couple of changes as mentioned, if you don't mind.

myii
myii reviewed Apr 26, 2019
View reviewed changes
docs/README.rst Outdated Show resolved Hide resolved
myii
myii reviewed Apr 26, 2019
View reviewed changes
docs/README.rst Outdated Show resolved Hide resolved
This was referenced Apr 26, 2019
Merged
Open
@daks
Copy link
Member Author

daks commented Apr 28, 2019

@myii is the README OK for you?

@daks daks marked this pull request as ready for review April 28, 2019 09:02
@myii
Copy link
Member

myii commented Apr 28, 2019

@daks Yes, that's fine. But the pre-salted images aren't being used, as updated in kitchen.yml in the template-formula.

@myii myii merged commit 400db3f into saltstack-formulas:master Apr 28, 2019
@myii
Copy link
Member

myii commented Apr 28, 2019

@daks Thanks for the effort, we got there in the end -- merged.

@daks daks deleted the docs/semantic-release branch April 28, 2019 10:11
@saltstack-formulas-travis
Copy link

🎉 This PR is included in version 0.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

myii added a commit to myii/cert-formula that referenced this pull request Jun 26, 2019
@myii
test(managed): get tests working for Fedora as well
7332d4b 
* Completes saltstack-formulas#23
@myii myii mentioned this pull request Jun 26, 2019
Merged
saltstack-formulas-travis pushed a commit that referenced this pull request Jun 26, 2019
@semantic-release-bot
chore(release): 0.3.2 [skip ci]
a11e13f 
## [0.3.2](v0.3.1...v0.3.2) (2019-06-26)

### Continuous Integration

* **kitchen+travis:** modify matrix to include `develop` platform ([ecda7e6](ecda7e6))

### Tests

* **managed:** get tests working for Fedora as well ([7332d4b](7332d4b)), closes [#23](#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myii myii myii approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daks @myii @saltstack-formulas-travis