Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_HEAD_REF if available #27

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

deeninetyone
Copy link

Fix #6 by using GITHUB_HEAD_REF if available

@dfreeman
Copy link
Member

Hi @deeninetyone, thanks for the PR! Can you describe what you're running into that requires the --openssl-legacy-provider flag?

@deeninetyone deeninetyone marked this pull request as draft April 21, 2023 13:55
@deeninetyone
Copy link
Author

Hi @deeninetyone, thanks for the PR! Can you describe what you're running into that requires the --openssl-legacy-provider flag?

Hi there! This is the error I'm getting:

$ ncc build
ncc: Version 0.20.5
ncc: Compiling file index.js
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:[19](https://github.com/deeninetyone/action-detect-and-tag-new-version/actions/runs/4754881998/jobs/8448269803#step:4:20))
    at Object.createHash (node:crypto:133:10)
    at hashOf (evalmachine.<anonymous>:1:1478571)
    at module.exports (evalmachine.<anonymous>:1:1480625)
    at runCmd (evalmachine.<anonymous>:1:46940)
    at 819 (evalmachine.<anonymous>:1:43967)
    at __webpack_require__ (evalmachine.<anonymous>:1:[21](https://github.com/deeninetyone/action-detect-and-tag-new-version/actions/runs/4754881998/jobs/8448269803#step:4:22)6)
    at startup (evalmachine.<anonymous>:1:353)
    at module.exports.8 (evalmachine.<anonymous>:1:385)
    at evalmachine.<anonymous>:1:395 {
  opensslErrorStack: [ 'error:0[30](https://github.com/deeninetyone/action-detect-and-tag-new-version/actions/runs/4754881998/jobs/8448269803#step:4:31)00086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

I've marked this WIP because the change assumes trying to get GITHUB_HEAD_REF will throw an exception if it's undefined, but seems that's not true from further testing

@deeninetyone deeninetyone marked this pull request as ready for review April 21, 2023 14:01
@deeninetyone
Copy link
Author

Right, this works for me. There's a test I can't get to pass, and I'm not sure why

Copy link

@code-ape code-ape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... I'm not a maintainer on this repo, but will let me leave a review and I really want this feature. Therefore, I present my minor code review as a rando that heavily uses this repo 😅

package.json Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@bmiselis
Copy link

bmiselis commented Aug 3, 2023

Our project would benefit from this being merged as well! @dfreeman any chance of this happening?

@DeanLa
Copy link

DeanLa commented May 20, 2024

Any chance this will be merged?
Also needing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action wouldn't work in workflow triggered by pull request
5 participants