-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GITHUB_HEAD_REF if available #27
base: master
Are you sure you want to change the base?
Conversation
Use internal nexus for build
Hi @deeninetyone, thanks for the PR! Can you describe what you're running into that requires the |
Hi there! This is the error I'm getting:
I've marked this WIP because the change assumes trying to get GITHUB_HEAD_REF will throw an exception if it's undefined, but seems that's not true from further testing |
Right, this works for me. There's a test I can't get to pass, and I'm not sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... I'm not a maintainer on this repo, but will let me leave a review and I really want this feature. Therefore, I present my minor code review as a rando that heavily uses this repo 😅
Our project would benefit from this being merged as well! @dfreeman any chance of this happening? |
Any chance this will be merged? |
Fix #6 by using GITHUB_HEAD_REF if available