Fix assertion for same DB in DbGuard
#532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #529 I ran into the issue that the assertion in
DbGuard
asserting that the DB is unchanged consistently fails.The underlying problem is that
NonNull::eq
not only compares the pointer but also the metadata which is unreliable for trait object pointersThis PR changes the assertion to use
std::ptr::addr_eq
which only compares the address without the metadata.Fixes #536