Remove bors.toml and update GitHub Actions
#507
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
| path: | | ||
| ~/.cargo/bin/ | ||
| ~/.cargo/registry/index/ | ||
| ~/.cargo/registry/cache/ | ||
| ~/.cargo/git/db/ | ||
| target/ | ||
| key: ${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}-${{ hashFiles('**/Cargo.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}- | ||
| ${{ runner.os }}-cargo- |
There was a problem hiding this comment.
What's your experience for using github action's cache directly vs https://github.com/Swatinem/rust-cache. Or does this set up caching in addition to Swatinem because https://github.com/actions-rust-lang/setup-rust-toolchain enables caching by default.
There was a problem hiding this comment.
I'm using a similar setup for other crates and it works fine to reduce job times. This is not in addition to anything else, this PR proposes to use https://github.com/dtolnay/rust-toolchain/.
Checking in a Cargo.lock file would make this more efficient.
There was a problem hiding this comment.
I don't really have any opinion on these things. Happy to trust your judgment here.
| path: | | ||
| ~/.cargo/bin/ | ||
| ~/.cargo/registry/index/ | ||
| ~/.cargo/registry/cache/ | ||
| ~/.cargo/git/db/ | ||
| target/ | ||
| key: ${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}-${{ hashFiles('**/Cargo.toml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-cargo-${{ steps.rust-toolchain.outputs.cachekey }}- | ||
| ${{ runner.os }}-cargo- |
There was a problem hiding this comment.
I don't really have any opinion on these things. Happy to trust your judgment here.
Another follow-up of #501.
Removes
bors.toml, because it's no longer used/needed (it seems salsa is using a merge queue now). Also removes the emptyrustfmt.toml.Updates some GitHub Actions to the latest, removes the
borsbranch push triggers, and removes the use of the unmaintainedactions-rsactions. Also bumps themdbookversions to the latest and adds cacheing for the rust build jobs.