feat: add timedPrompt method #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdonnalley do you have a specific example of why a timed prompt would be needed? I am not really seeing the value of this. |
@peternhale I'm using it here salesforcecli/cli#172 to timeout the prompt that asks which command the user wants to run. In my mind it's a bad idea to let the prompt run indefinitely - but I could be convinced otherwise |
mdonnalley
force-pushed
the
mdonnalley/timed-prompt
branch
from
8aa5f2e to
d820070
Compare
peternhale
approved these changes
Feb 28, 2022
mdonnalley
force-pushed
the
mdonnalley/timed-prompt
branch
from
530ecc1 to
702b623
Compare
mdonnalley
force-pushed
the
mdonnalley/timed-prompt
branch
from
702b623 to
7d3d023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
timedPromptmethod toPrompter, so that we can timeout prompts when necessaryWhat issues does this PR fix or reference?
@W-10713661@