feat: add default answer param to confirm #215
Conversation
@W-12521197@
| * @return true if the user confirms, false if they do not. | ||
| */ | ||
| public async confirm(message: string, ms = 10000): Promise<boolean> { | ||
| return this.prompter.confirm(message, ms); | ||
| public async confirm(message: string, ms = 10000, defaultAnswer = true): Promise<boolean> { |
There was a problem hiding this comment.
UIs usually ask for confirmation before doing an expensive/destructive operation and default to no to ensure the user really wants to do it.
Let's say my plugin has a bunch of commands that delete stuff in an org, I would have to set defaultAnswer to no on each command. It's easy to forget to do it and may cause a unexpected outcome for the user.
Since the prompter is the one defaulting to true and it's public this change would require a major bump:
https://github.com/salesforcecli/sf-plugins-core/blob/main/src/ux/prompter.ts#L61
There was a problem hiding this comment.
@cristiand391 This is a utility function and it has no concept of what the implications are of a yes or no answer. Those decisions are best done by the caller. Making the default true is protecting backward compatibility.
@W-12521197@