Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm/type improvements #172

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Sm/type improvements #172

merged 5 commits into from
Jan 10, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Dec 30, 2022 •
edited
Loading

revert #33 (causes downstream failures because types don't match oclif's).

  • FWIW, I think TS is just wrong here (undefined were being filtered out)

things that extend Deployer can be optional.

@W-12285444@

@mshanemc mshanemc requested a review from peternhale December 30, 2022 23:11
@mshanemc mshanemc mentioned this pull request Dec 31, 2022
Merged
@peternhale peternhale merged commit 1422441 into main Jan 10, 2023
@peternhale peternhale deleted the sm/type-improvements branch January 10, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternhale peternhale peternhale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @peternhale