Merge pull request #610 from salesforcecli/mdonnalley/flush-warnings

feat: flush intra-command warnings at the end

src/sfCommand.ts

@@ -153,6 +153,7 @@ export abstract class SfCommand<T> extends Command {
   public configAggregator!: ConfigAggregator;
 
   private warnings: SfCommand.Warning[] = [];
+  private warningsToFlush: SfCommand.Warning[] = [];
   private ux: Ux;
   private lifecycle: Lifecycle;
 
@@ -330,7 +331,7 @@ export abstract class SfCommand<T> extends Command {
     }
     // eslint-disable-next-line @typescript-eslint/require-await
     this.lifecycle.onWarning(async (warning: string) => {
-      this.warn(warning);
+      this.warningsToFlush.push(warning);
     });
     const options = {
       Command: this.ctor,
@@ -398,6 +399,16 @@ export abstract class SfCommand<T> extends Command {
     throw sfCommandError;
   }
 
+  // eslint-disable-next-line @typescript-eslint/require-await, @typescript-eslint/no-explicit-any
+  protected async finally(_: Error | undefined): Promise<any> {
+    // flush warnings
+    this.warningsToFlush.forEach((warning) => {
+      this.warn(warning);
+    });
+
+    return super.finally(_);
+  }
+
   public abstract run(): Promise<T>;
 }