Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor npmName and export it #780

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Apr 4, 2024

What does this PR do?

  1. update deps to unblock devScripts automerges
  2. refactor npmName to a function/interface [was not exported or used outside this library, no breaking changes]
  3. export npmName top-level (it's already a dependency of plugin-release-management and mostly duplicated here: https://github.com/salesforcecli/plugin-release-management/blob/main/src/codeSigning/NpmName.ts)
  4. UT for npmName where none existed in either repo (found a bug!)

What issues does this PR fix or reference?

@W-15429611@

@mshanemc mshanemc changed the title Sm/refactor npm name fix: refactor npmName and export it Apr 4, 2024
@@ -14,6 +14,7 @@ import { SfError } from '@salesforce/core';
export const setErrorName = (err: SfError, name: string): SfError => {
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore override readonly .name field
// eslint-disable-next-line no-param-reassign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 - already in action

@WillieRuemmele WillieRuemmele merged commit b2c0a8d into main Apr 5, 2024
11 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/refactor-npm-name branch April 5, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants