Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow any 403 response to continue verification #662

Merged
merged 2 commits into from
Dec 1, 2023
Merged

feat: allow any 403 response to continue verification #662

merged 2 commits into from
Dec 1, 2023

Conversation

kyle-blair
Copy link
Contributor

@kyle-blair kyle-blair commented Nov 30, 2023

What does this PR do?

Allows any 403 response to proceed to plugin verification bypass. Previously restricted to errors with a more specific 403 (Forbidden) message.

What issues does this PR fix or reference?

forcedotcom/cli/issues/2584
@W-14581522@

Copy link

Thanks for the contribution! Before we can merge this, we need @kyle-blair to sign the Salesforce Inc. Contributor License Agreement.

@kyle-blair
Copy link
Contributor Author

@mshanemc

@kyle-blair
Copy link
Contributor Author

FYI, after completing the CLA form I received this message from the url https://cla.salesforce.com/sign-cla?prUrl=https%3A%2F%2Fgithub.com%2Fsalesforcecli%2Fplugin-trust%2Fpull%2F662

Could not sign the CLA, please contact: [email protected]

I tried the link again and it said

You already signed the CLA on 2023-11-30

src/shared/installationVerification.ts Outdated Show resolved Hide resolved
@mshanemc mshanemc merged commit 84fff9e into salesforcecli:main Dec 1, 2023
12 checks passed
@kyle-blair kyle-blair deleted the make-verification-failure-less-specific branch December 1, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants