fix: replace request with got for HTTP calls
#289
Conversation
| @@ -2,6 +2,7 @@ | |||
| "extends": "@salesforce/dev-config/tsconfig", | |||
| "compilerOptions": { | |||
| "outDir": "lib", | |||
| "allowSyntheticDefaultImports": true, | |||
There was a problem hiding this comment.
wasn't able to build the plugin without this 🤷🏼
TooTallNate/node-agent-base#56
| throw new Error(`Unexpected test url - ${url}`); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
I think this UT was from when plugin-trust was doing raw HTTP calls to npm, we switched to npm here:
#154
so no need to stub got, the error is thrown from here:
plugin-trust/src/shared/npmCommand.ts
Line 189 in 1affd57
| @@ -509,109 +546,6 @@ describe('InstallationVerification Tests', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it.skip('server error', async () => { | |||
There was a problem hiding this comment.
ditto, this UT was testing the HTTP calls to npm, we run npm show now (see prev comment)
|
QA notes: linked plugin-trust not tested: proxies |
What does this PR do?
replace
requestdependency withgot.request is deprecated: https://www.npmjs.com/package/request
What issues does this PR fix or reference?
@W-0@