fix: verify fails if node not installed #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-9930707@
RodEsp
previously requested changes
Sep 22, 2021
mshanemc
approved these changes
Sep 23, 2021
Co-authored-by: Shane McLaughlin <[email protected]>
Co-authored-by: Shane McLaughlin <[email protected]>
maggiben
approved these changes
Sep 23, 2021
maggiben
approved these changes
Sep 23, 2021
maggiben
approved these changes
Sep 23, 2021
mshanemc
approved these changes
Sep 24, 2021
RodEsp
approved these changes
Sep 24, 2021
peternhale
commented
Sep 24, 2021
| @@ -6,9 +6,12 @@ | |||
| */ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
|
|
|||
| import { type as osType } from 'os'; | |||
There was a problem hiding this comment.
@maggiben why the alias? This confuses old people like me :) I would rather see os.type()
There was a problem hiding this comment.
@peternhale that was me.
Because if you want to do os.type() then you have to bring in all of os with import * as os from 'os';.
So you can do import { type } from 'os'; to only bring in what you need but then calling type() isn't very descriptive either, so I aliased it to osType();
RodEsp
reviewed
Sep 24, 2021
RodEsp
reviewed
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-9930707@
What does this PR do?
What issues does this PR fix or reference?
forcedotcom/cli#1198