Sm/nuts for plugin install #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
added a commit
that referenced
this pull request
Sep 24, 2021
* fix: verify fails if node not installed @W-9930707@ * chore: code cleanup * chore: code cleanup * test: node in slim an global * chore: code clean + path for win * Update src/lib/npmCommand.ts Co-authored-by: Shane McLaughlin <[email protected]> * Update src/lib/npmCommand.ts Co-authored-by: Shane McLaughlin <[email protected]> * chore: streamline code & update some comments * fix: remmove unnecessary string template * test: run nuts from CI * test: can't use answers to prompts on windows * fix: make sure node filepath is executable * chore: update unit tests so error messages are more descriptive * test: run nuts on branches, partial nuts on windows (#168) * test: add telemetry ack file * test: ignore errors on deleting testProjects * test: store correct filename * test: can't write to non-existent dir * test: smaller test plugin, json in ack file * test: no nuts for windows Co-authored-by: Benjamin Maggi <[email protected]> Co-authored-by: Shane McLaughlin <[email protected]> Co-authored-by: Rodrigo Espinosa de los Monteros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
runs nuts in CI on branches of plugin-trust [they were written but not running automatically]
runs a subset of the nuts (that don't involve prompts) on windows. That verifies node executable can be used and covers
What issues does this PR fix or reference?
testing for @W-9930707@
No functional changes, only CI and NUTs