-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use npm instead of http #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work getting all this cleaned up. Plugin-trust is super critical because it'll completely block plugin instalation if it's not working OK.
I'd like to see a NUT for this that
- installs any known, good signed plugin (ex: plugin-user)
- verifies it installs without the error message
- puts an unsigned plugin on the allowlist
- installs some known good unsigned plugin (see list https://github.com/mshanemc/awesome-sfdx-plugins. I'd suggest Jochen's jayree plugin)
- installs some unsigned plugin not on the allow list to verify the warning is happening
I'm not sure if there's a good NUT way to verify that this change solves private npm registry, but the NUT I'm describing would verify that the normal public repository functionality isn't impacted by these changes.
Hi @mshanemc I added the NUTs you suggested, luckily |
QA: can verify existing plugins are signed |
What does this PR do?
Replaces http commands in favor of npm commands
What issues does this PR fix or reference?
@W-9642544@