-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle errors emitted from SfCommand #432
Conversation
QA notes:
✅ err event object is included in the telemetry payload:
logs only contains 1 object for the after:
|
this.orgUsername = flags['targetusername'] as unknown as string; | |
this.devHubOrgUsername = flags['targetdevhubusername'] as unknown as string; |
plugin-telemetry/src/uploader.ts
Lines 65 to 67 in a604c0b
event.orgId = await getOrgId(false, asString(event.orgUsername)); | |
// eslint-disable-next-line no-await-in-loop | |
event.devHubId = await getOrgId(true, asString(event.devHubUsername)); |
sfCommandError
event and send to app insightsexit
running beforecmdErr
orsfCommandError
have finished runningtargetusername
andtargetdevhubusername
withtarget-org
andtarget-dev-hub
, respectivelyorgType
andapiVersion
fromCOMMAND_ERROR
eventsorgApiVersion
,orgId
,devhubApiVersion
, anddevhubId
to allCOMMAND_ERROR
andCOMMAND_EXECUTION
events@W-12370126@