Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isRestDeploy correctly handles org-metadata-rest-deploy config c… #535

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

WillieRuemmele
Copy link
Contributor

…onversion

What does this PR do?

isRestDeploy method respects the sf/sfdx config value conversion

comments in the method are now correct. SOAP is default, unless the config/env var is true

What issues does this PR fix or reference?

@W-11390183@

@mshanemc
Copy link
Contributor

mshanemc commented Jul 6, 2022

QA notes

./../plugin-source/bin/dev force:source:deploy -p force-app deploys soap
sfdx config:set restDeploy=true and repeat of the same command
✅ *** Deploying with REST API v55.0 ***
[due to infra issues, I'm not waiting for these deploys to finish. I can confirm the api choice from the ui]

source:convert and ../../plugin-source/bin/dev force:mdapi:deploy --deploydir mdapiOut --wait 100
✅ *** Deploying with REST *** (config is still set)
../../plugin-source/bin/dev force:mdapi:deploy --deploydir mdapiOut --wait 100 --soapdeploy
✅ *** Deploying with SOAP ***
sfdx config:unset restDeploy
../../plugin-source/bin/dev force:mdapi:deploy --deploydir mdapiOut --wait 100
✅ *** Deploying with SOAP ***

../../plugin-source/bin/dev force:source:delete -p force-app/main/default/classes/GeocodingServiceTest.cls
✅ *** Deleting with SOAP API ***

sfdx config:set restDeploy=true
../../plugin-source/bin/dev force:source:delete -p force-app/main/default/classes/TestPropertyController.cls

✅ *** Deleting with REST API ***

@mshanemc mshanemc merged commit dd7e776 into main Jul 6, 2022
@mshanemc mshanemc deleted the wr/restDeployRespectsOrgDeploy branch July 6, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants