Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include correct username for deploy:report in async deploy #392

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

WillieRuemmele
Copy link
Contributor

@WillieRuemmele WillieRuemmele commented Jan 18, 2022

What does this PR do?

organizes formatters specific to mdapi under formatters/mdapi and source under formatters/source
adds -u <username> output to async deploys

 ➜  sfdx force:source:deploy -p force-app/main/default/classes -w 0             
*** Deploying v52.0 metadata with SOAP API v53.0 connection ***
Deploy ID: 0Af1F00002BjnhfSAB
Deploy has been queued. 

Run sfdx force:source:deploy:cancel -i 0Af1F00002BjnhfSAB -u [email protected] to cancel the deploy.
Run sfdx force:source:deploy:report -i 0Af1F00002BjnhfSAB -u [email protected] to get the latest status.
 ➜  sfdx force:mdapi:beta:deploy -d object -w 0                                  
Deploy ID: 0Af1F00002BkUN8SAN
*** Deploying with SOAP ***
Deploy has been queued. 

Run sfdx force:mdapi:deploy:cancel -i 0Af1F00002BkUN8SAN -u [email protected] to cancel the deploy.
Run sfdx force:mdapi:beta:deploy:report -i 0Af1F00002BkUN8SAN -u [email protected] to get the latest status.

What issues does this PR fix or reference?

@W-5556853@

@cristiand391
Copy link
Member

QA notes:
Using dreamhouse-lwc

✅ source deploy shows default username in the project

sfdx force:source:deploy --sourcepath force-app -w 0
...
Run sfdx force:source:deploy:cancel -i 0AfP000001LPu3DKAT -u [email protected] to cancel the deploy.
Run sfdx force:source:deploy:report -i 0AfP000001LPu3DKAT -u [email protected] to get the latest status.

✅ metadata deploy shows default username in the project

sfdx force:mdapi:beta:deploy -d mdapi -w 0
...
Run sfdx force:mdapi:deploy:cancel -i 0AfP000001LPuIjKAL -u [email protected] to cancel the deploy.
Run sfdx force:mdapi:beta:deploy:report -i 0AfP000001LPuIjKAL -u [email protected] to get the latest status.

@cristiand391 cristiand391 merged commit f58ff25 into main Jan 20, 2022
@cristiand391 cristiand391 deleted the wr/includeUsername branch January 20, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants