Wr/destructive deploy #230

WillieRuemmele · 2021-09-28T23:16:59Z

WARNING: BEFORE MERGING BUMP SDR VERSION TO 5.0.0

What does this PR do?

a draft PR adding destructive operations to the deploy command

QA notes:
link this SDR PR

generate manifests with source:manifest:create

What issues does this PR fix or reference?

@W-9892380@

…n-source into wr/destructiveDeploy

mshanemc · 2021-10-13T14:58:37Z

src/deployCommand.ts

+      throw SfdxError.create('@salesforce/plugin-source', 'deploy', 'MissingRequiredParam', [this.xorFlags.join(', ')]);
+    }
+
+    if ((this.flags.predestructivechanges || this.flags.postdestructivechanges) && !this.flags.manifest) {


Why custom validation rather than dependsOn : ['manifest'] on these flags?

mshanemc · 2021-10-13T15:00:27Z

src/formatters/deployResultFormatter.ts

@@ -107,7 +108,7 @@ export class DeployResultFormatter extends ResultFormatter {

  protected displaySuccesses(): void {
    if (this.isSuccess() && this.fileResponses?.length) {
-      const successes = this.fileResponses.filter((f) => f.state !== 'Failed');
+      const successes = this.fileResponses.filter((f) => f.state !== 'Failed' && f.state !== 'Deleted');


Suggested change

const successes = this.fileResponses.filter((f) => f.state !== 'Failed' && f.state !== 'Deleted');

const successes = this.fileResponses.filter((f) => !['Failed','Deleted'].includes(f.state);

src/commands/force/source/deploy.ts

mshanemc · 2021-10-13T15:09:05Z

test/nuts/deployDestructive.nut.ts

+    execCmd(`force:source:manifest:create --metadata ${metadata} --manifesttype ${manifesttype}`);
+  };
+
+  const query = (


Suggested change

const query = (

const sourceMemberQuery = (

mshanemc · 2021-10-13T15:12:51Z

test/nuts/deployDestructive.nut.ts

+  ): { result: { records: Array<{ IsNameObsolete: boolean }> } } => {
+    return JSON.parse(
+      exec(
+        `sfdx force:data:soql:query -q "SELECT IsNameObsolete FROM SourceMember WHERE MemberType='${memberType}' AND MemberName='${memberName}'" -t --json`,


one alternative is to create a Connection (since you have the username in testkit.project.setup from the org:create command) and use the query or singleRecordQuery features there. It's probably faster than the shell route and you can use its support

mshanemc · 2021-10-13T15:14:38Z

test/nuts/deployDestructive.nut.ts

+  });
+
+  describe('errors', () => {
+    it('should throw an error when a destructive flag is passed without the manifest flag', () => {


what happens when a value of destructive flag is passed, but the file doesn't exist (typo, or user in wrong directory level, etc)

test/nuts/deployDestructive.nut.ts

mshanemc · 2021-10-13T19:08:42Z

test/nuts/deployDestructive.nut.ts

-        { silent: true }
-      )
-    ) as { result: { records: Array<{ IsNameObsolete: boolean }> } };
+  const isNameObsolete = async (memberType: string, memberName: string): Promise<boolean> => {


that turned out nice.

mshanemc

looks OK except for the xorFlag stuff disappearing

I assume the tests would have caught that if you had SDRv5 available?

mshanemc · 2021-10-13T19:10:11Z

src/deployCommand.ts

@@ -21,18 +21,6 @@ export abstract class DeployCommand extends SourceCommand {
  });

  protected deployResult: DeployResult;
-
-  protected validateFlags(): void {
-    // verify that the user defined one of the flag names specified in requiredFlags property


don't you still need the xorFlag validations?

it's handled in the SourceCommand base class still - that method overrode it to add the post/pre flag validation that's fixed with dependsOn property in the flag definition

shetzel

LGTM

maggiben · 2021-10-21T02:18:14Z

test/nuts/deployDestructive.nut.ts

+      const { apexName } = createApexClass();
+
+      createManifest('ApexClass:GeocodingService', 'package');
+      createManifest(`ApexClass:${apexName}`, 'pre');


maybe you want to use the post name here ?

…ename * fix: show conflicts from both remote and local, including remote filename * test: better output, workaroun for Audience type * fix: push gets its own formatter for json reasons * fix: missing pull messages * chore: bump SDR to 4.5.7 (#253) * chore(release): 1.2.3 [ci skip] * Updated/Added CODEOWNERS with ECCN * chore(release): 1.2.4 [ci skip] * chore: sync .gitignore [skip-validate-pr] (#251) Authored via Leif * test: parallelize nuts, exclude async deploy nut * test: one NUT for special types * test: remove tracking NUTs * ci: custom nut commands * test: fix folderTypes, cross-env for windows * test: cross-env for windows SEED_FILTER, nyc only top-level * ci: no sha; change nut order * test: deploy nuts in parallel * ci: disable async nuts * test: exclude async nuts * test: revert async-exclude * test: revert tsconfig, revert config.yml * test: exclude env for seeds * feat: mark ignores * feat: status shows remote ignores * refactor: consistent naming of command classes * refactor: push feedback * style: comment is no longer a question * test: ebikes from clone instead of fs * fix: status flags are better * test: nuts with conn adjusted for git checkout * chore: bump sdr for Created state fix * test: unignore profiles * test: was not using ebikes, revert * chore: change status' flags in snapshot * refactor: move status logic to STL * test: update ignore nut * style: formatting line length * fix: push uses correct json * test: update tests for new push json format * test: ut on lts, not node17 * Wr/destructive deploy (#230) * fix: implementing destructive change deploy, 1 NUT * chore: add NUTs, fix UTs * chore: post-review board updates * chore: fix linting * chore: minor updates to flag logic, redo NUT query method * chore: remove unnecessary checks in NUTs * chore: bump SDR to 5, include deploy:destructive in NUTs * chore(release): 1.2.5 [ci skip] * fix: use cross-env for test:nuts script (#260) * chore(release): 1.2.6 [ci skip] * chore: unhide beta commands * chore: bump SDR and STL * test: and tracking nuts * ci: windows UT * test: nuts are hub-auth-agnostic * ci: windows only * ci: restore windows tests Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: SF-CLI-BOT <[email protected]> Co-authored-by: svc-scm <[email protected]> Co-authored-by: Steve Hetzel <[email protected]>

* refactor: redo open for sfdx-core dependency reasons * test: ebikes for nuts * feat: source tracking commands in source:beta * test: nuts for source tracking commands * docs: new subtopics * chore: remove imported asserted project/org * chore: restore breaking comma * chore: bump source tracking version * chore: rebuild with latest lockfile * refactor: feedback from WR * style: typo and cleaner concats * chore: pr feedback * refactor: pull more like retrieve * refactor: status formatter * test: remove unused export * chore: bump stl * fix: missing header for pull * fix: show conflicts from both remote and local, including remote filename * test: better output, workaroun for Audience type * refactor: consistent naming of command classes * refactor: push feedback * style: comment is no longer a question * test: ebikes from clone instead of fs * fix: status flags are better * test: nuts with conn adjusted for git checkout * chore: bump sdr for Created state fix * test: unignore profiles * test: was not using ebikes, revert * chore: change status' flags in snapshot * feat: show conflicts from both remote and local, including remote filename * fix: show conflicts from both remote and local, including remote filename * test: better output, workaroun for Audience type * fix: push gets its own formatter for json reasons * fix: missing pull messages * chore: bump SDR to 4.5.7 (#253) * chore(release): 1.2.3 [ci skip] * Updated/Added CODEOWNERS with ECCN * chore(release): 1.2.4 [ci skip] * chore: sync .gitignore [skip-validate-pr] (#251) Authored via Leif * test: parallelize nuts, exclude async deploy nut * test: one NUT for special types * test: remove tracking NUTs * ci: custom nut commands * test: fix folderTypes, cross-env for windows * test: cross-env for windows SEED_FILTER, nyc only top-level * ci: no sha; change nut order * test: deploy nuts in parallel * ci: disable async nuts * test: exclude async nuts * test: revert async-exclude * test: revert tsconfig, revert config.yml * test: exclude env for seeds * feat: mark ignores * feat: status shows remote ignores * refactor: consistent naming of command classes * refactor: push feedback * style: comment is no longer a question * test: ebikes from clone instead of fs * fix: status flags are better * test: nuts with conn adjusted for git checkout * chore: bump sdr for Created state fix * test: unignore profiles * test: was not using ebikes, revert * chore: change status' flags in snapshot * refactor: move status logic to STL * test: update ignore nut * style: formatting line length * fix: push uses correct json * test: update tests for new push json format * test: ut on lts, not node17 * Wr/destructive deploy (#230) * fix: implementing destructive change deploy, 1 NUT * chore: add NUTs, fix UTs * chore: post-review board updates * chore: fix linting * chore: minor updates to flag logic, redo NUT query method * chore: remove unnecessary checks in NUTs * chore: bump SDR to 5, include deploy:destructive in NUTs * chore(release): 1.2.5 [ci skip] * fix: use cross-env for test:nuts script (#260) * chore(release): 1.2.6 [ci skip] * chore: unhide beta commands * chore: bump SDR and STL * test: and tracking nuts * ci: windows UT * test: nuts are hub-auth-agnostic * ci: windows only * ci: restore windows tests Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: SF-CLI-BOT <[email protected]> Co-authored-by: svc-scm <[email protected]> Co-authored-by: Steve Hetzel <[email protected]> * Sm/quiet-flag (#259) * fix: push gets its own formatter for json reasons * fix: missing pull messages * feat: mark ignores * feat: status shows remote ignores * refactor: move status logic to STL * test: update ignore nut * style: formatting line length * fix: push uses correct json * test: update tests for new push json format * test: ut on lts, not node17 * test: include tracking nuts * feat: quiet flag on push (for stdout and json) * test: put the individual tracking nuts back * feat: quiet shows only failures in json * refactor: simplify quiet logic * test: ut for formatter with quiet * feat: show ignored if any * refactor: ignored as first column * fix: no spinner for conflict check on --overwrite * fix: early exit when there are no results * fix: handle no-result (deletes only, or no changes) * chore: bump sdr and stl Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: SF-CLI-BOT <[email protected]> Co-authored-by: svc-scm <[email protected]> Co-authored-by: Steve Hetzel <[email protected]>

WillieRuemmele added 6 commits September 27, 2021 17:13

fix: implementing destructive change deploy, 1 NUT

8f1a102

chore: add NUTs, fix UTs

1fc0c35

Merge branch 'main' into wr/destructiveDeploy

82d5a0b

chore: post-review board updates

ff975d2

Merge branch 'wr/destructiveDeploy' of github.com:salesforcecli/plugi…

f9ba0ac

…n-source into wr/destructiveDeploy

chore: fix linting

576ff7f

mshanemc reviewed Oct 13, 2021

View reviewed changes

chore: minor updates to flag logic, redo NUT query method

d705e88

mshanemc reviewed Oct 13, 2021

View reviewed changes

test/nuts/deployDestructive.nut.ts Outdated Show resolved Hide resolved

mshanemc reviewed Oct 13, 2021

View reviewed changes

mshanemc requested changes Oct 13, 2021

View reviewed changes

chore: remove unnecessary checks in NUTs

53b021f

shetzel approved these changes Oct 14, 2021

View reviewed changes

maggiben reviewed Oct 21, 2021

View reviewed changes

WillieRuemmele added 2 commits October 21, 2021 08:30

Merge branch 'main' into wr/destructiveDeploy

ce8b4f4

chore: bump SDR to 5, include deploy:destructive in NUTs

154cf90

WillieRuemmele merged commit e18c197 into main Oct 21, 2021

WillieRuemmele deleted the wr/destructiveDeploy branch October 21, 2021 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wr/destructive deploy #230

Wr/destructive deploy #230

WillieRuemmele commented Sep 28, 2021 •

edited

Loading

mshanemc Oct 13, 2021

mshanemc Oct 13, 2021

mshanemc Oct 13, 2021

mshanemc Oct 13, 2021

mshanemc Oct 13, 2021

mshanemc Oct 13, 2021

mshanemc left a comment

mshanemc Oct 13, 2021

WillieRuemmele Oct 13, 2021 •

edited

Loading

shetzel left a comment

maggiben Oct 21, 2021

	const successes = this.fileResponses.filter((f) => f.state !== 'Failed' && f.state !== 'Deleted');
	const successes = this.fileResponses.filter((f) => !['Failed','Deleted'].includes(f.state);

Wr/destructive deploy #230

Wr/destructive deploy #230

Conversation

WillieRuemmele commented Sep 28, 2021 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshanemc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillieRuemmele Oct 13, 2021 • edited Loading

Choose a reason for hiding this comment

shetzel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillieRuemmele commented Sep 28, 2021 •

edited

Loading

WillieRuemmele Oct 13, 2021 •

edited

Loading