fix: trim metadata type, and name to prevent unnecessary errors #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Aug 24, 2021
src/componentSetBuilder.ts
Outdated
| @@ -82,10 +82,10 @@ export class ComponentSetBuilder { | |||
| metadata.metadataEntries.forEach((rawEntry) => { | |||
| const splitEntry = rawEntry.split(':'); | |||
There was a problem hiding this comment.
Suggested change
| const splitEntry = rawEntry.split(':'); | |
| const splitEntry = rawEntry.split(':').map(entry => entry.trim()) |
will trim both, so you don't have to trim in 2 places OR worry about the untrimmed type on line 87
shetzel
approved these changes
Aug 25, 2021
shetzel
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
deploy -m "ApexClass: GeocodingService"would cause ano source backed componentsError, trim the metadata type and name to ensure we're parsing everything correctlyWhat issues does this PR fix or reference?
@W-9803972@ forcedotcom/cli#1151