Wr/manifest generate #168
Wr/manifest generate #168
Conversation
| description: messages.getMessage('flags.outputdir'), | ||
| }), | ||
| }; | ||
| public requiredFlags = ['metadata', 'sourcepath']; |
There was a problem hiding this comment.
I think a better name for this would be xorFlags, meaning 1 and only 1 of them must be set when running the command. I think this should really move into oclif at some point too.
src/sourceCommand.ts
Outdated
| @@ -21,6 +21,7 @@ export type ProgressBar = { | |||
|
|
|||
| export abstract class SourceCommand extends SfdxCommand { | |||
| public static readonly DEFAULT_SRC_WAIT_MINUTES = 33; | |||
| public requiredFlags: string[] = []; | |||
There was a problem hiding this comment.
I think this should be protected not public.
src/sourceCommand.ts
Outdated
| @@ -30,6 +31,15 @@ export abstract class SourceCommand extends SfdxCommand { | |||
| return getBoolean(this.flags, 'json', false); | |||
| } | |||
|
|
|||
| protected validateFlags(flags: string[]): void { | |||
There was a problem hiding this comment.
We don't need to pass in the flags. SourceCommand has them as this.flags
test/nuts/create.nut.ts
Outdated
| }, | ||
| setupCommands: [ | ||
| 'sfdx force:org:create -f config/project-scratch-def.json --setdefaultusername --wait 10 --durationdays 1', | ||
| 'sfdx force:source:deploy -p force-app', |
There was a problem hiding this comment.
Why does the test need to create an org and deploy as part of setup?
There was a problem hiding this comment.
I figured that way it would validate that the generated manifest was would work with a deploy. SDR should be verifying that getPackageXml() returns a valid package... but I thought it would be pretty easy to do here too
test/nuts/create.nut.ts
Outdated
| ' <members>TestSampleDataController</members>\n' + | ||
| ' <name>ApexClass</name>\n' + | ||
| ' </types>\n' + | ||
| ' <version>52.0</version>\n' + |
There was a problem hiding this comment.
Unless you override the API version this will fail as soon as 52.0 is not current.
* fix: bump SDR to 4.0.2 * chore: disable sfdx NUTs * chore: disable sfdx executible in generateNut
command-snapshot.json
Outdated
| "metadata", | ||
| "outputdir", | ||
| "sourcepath", | ||
| "targetusername" |
There was a problem hiding this comment.
@shetzel to use SfdxCommand's standardized --apiversion flag I had to set supportsUsername=true which also includes the --targetusername... Do you think it would be better to duplicate the apiversion flag?
There was a problem hiding this comment.
Unless the command will use that flag (-u) I would not set supportsUsername=true. Just duplicate the apiversion flag. There might be a way to reference it without duplicating.
…-source into wr/manifestGenerate
What does this PR do?
adds the
sfdx force:source:manifest:createcommand.I think that the NUT coverage should be enough, the command is so small that unit tests seemed extra when the
ComponentSetBuilderis already coveredWhat issues does this PR fix or reference?
@W-9608078@