fix: deploy errors are reported properly #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Jul 13, 2021
mshanemc
approved these changes
Jul 19, 2021
| @@ -73,15 +78,26 @@ export const getDeployResponse = ( | |||
| type: DeployResponseType, | |||
| overrides?: Partial<MetadataApiDeployStatus> | |||
| ): MetadataApiDeployStatus => { | |||
| const response = { ...baseDeployResponse, ...overrides }; | |||
| const response = JSON.parse(JSON.stringify({ ...baseDeployResponse, ...overrides })) as MetadataApiDeployStatus; | |||
There was a problem hiding this comment.
probably worth a comment as to why the parse/stringify is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deploy errors are in the JSON output but not being displayed in stdout in all cases. This was due to the code assuming that the response contained
DeployMessage[]but it can also (unfortunately) returnDeployMessage.Deploy errors are now displayed in the stdout table format.
What issues does this PR fix or reference?
@W-9596635@